Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ET-741, PRMTR-206, TCMN-47: Promoter Listeners improvements #1311

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b8ce89f
Version bump to 4.11.4
bordoni Feb 20, 2020
e078d96
Merge branch 'master' of github.com:moderntribe/tribe-common into rel…
bordoni Feb 26, 2020
5aac02d
ECP-345 - Add check if the_content filter is running to prevent it fr…
jesseeproductions Mar 2, 2020
f023ebb
ECP-345 - readme change
jesseeproductions Mar 2, 2020
ea9eafa
Make sure sourceId is always an ID
mitogh Mar 4, 2020
7a9c8ac
Merge branch 'master' into spotfix/ET-741-promoter-listeners
mitogh Mar 4, 2020
408c4b3
Removal of merge conflict result
mitogh Mar 4, 2020
131d85d
ECP-345 - add automated test that would fail if the doing_filter chec…
jesseeproductions Mar 5, 2020
21d6f9b
ECP-345 - commenting fixes
jesseeproductions Mar 5, 2020
4ecaa22
ECP-345 - revise initial test and add another
jesseeproductions Mar 5, 2020
b050b44
Merge branch 'master' into release/B20.03
sc0ttkclark Mar 5, 2020
03c35bc
Merge branch 'release/B20.03' into spotfix/ET-741-promoter-listeners
sc0ttkclark Mar 5, 2020
4fc4670
Reactivate PHPCS github action
bordoni Mar 6, 2020
a9cbcef
Merge branch 'release/B20.03' into spotfix/ET-741-promoter-listeners
bordoni Mar 6, 2020
d8fed18
Remove .mo files from repo as well as .min.js files
bordoni Mar 6, 2020
c98a7dd
Replace `sys_get_temp_dir` with native `get_temp_dir`
mitogh Mar 7, 2020
8935b1a
Merge pull request #1314 from moderntribe/spotfix/remove-compile-files
bordoni Mar 7, 2020
614c734
Added context to Georgia
andrasguseo Feb 27, 2020
a3da082
Merge pull request #1316 from moderntribe/spotfix/add-context-to-geor…
lucatume Mar 9, 2020
2c9144e
Merge branch 'release/B20.03' into fix/ECP-345-check-doing-filter
jesseeproductions Mar 9, 2020
b6a467a
Merge pull request #1310 from moderntribe/fix/ECP-345-check-doing-filter
jesseeproductions Mar 9, 2020
0db6266
Merge branch 'release/B20.03' into spotfix/tmp_directory
mitogh Mar 9, 2020
ae78345
Merge pull request #1315 from moderntribe/spotfix/tmp_directory
mitogh Mar 9, 2020
640508d
Add changelog entry for Promoter Observers
mitogh Mar 9, 2020
12870d7
Merge branch 'release/B20.03' into spotfix/ET-741-promoter-listeners
mitogh Mar 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 26 additions & 26 deletions .github/workflows/phpcs.yml
@@ -1,26 +1,26 @@
#name: 'PHP CodeSniffer'
#on:
# pull_request:
# paths:
# - 'src/**.php'
# - '*.php'
#jobs:
# phpcs:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v1
# with:
# fetch-depth: 100
# - name: Get Composer Cache Directory
# id: composer-cache
# run: |
# echo "::set-output name=dir::$(composer config cache-files-dir)"
# - uses: actions/cache@v1
# with:
# path: ${{ steps.composer-cache.outputs.dir }}
# key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
# restore-keys: |
# ${{ runner.os }}-composer-
# - uses: moderntribe/action-tribe-phpcs@master
# with:
# github-bot-token: ${{ secrets.GH_BOT_TOKEN }}
name: 'PHP CodeSniffer'
on:
pull_request:
paths:
- 'src/**.php'
- '*.php'
jobs:
phpcs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
with:
fetch-depth: 100
- name: Get Composer Cache Directory
id: composer-cache
run: |
echo "::set-output name=dir::$(composer config cache-files-dir)"
- uses: actions/cache@v1
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-
- uses: moderntribe/action-tribe-phpcs@master
with:
github-bot-token: ${{ secrets.GH_BOT_TOKEN }}
5 changes: 3 additions & 2 deletions .gitignore
Expand Up @@ -30,8 +30,9 @@ vendor/freemius/languages/*.po

# Resources Ignoring
src/resources/**/app
src/resources/css/**
src/resources/**/*.min.js
src/resources/css
src/resources/js/**/*.min.js

# get from translate.wordpress.org as needed
lang/*.po
lang/*.mo
Binary file removed lang/tribe-common-af.mo
Binary file not shown.
Binary file removed lang/tribe-common-ar.mo
Binary file not shown.
Binary file removed lang/tribe-common-bg_BG.mo
Binary file not shown.
Binary file removed lang/tribe-common-ca.mo
Binary file not shown.
Binary file removed lang/tribe-common-cs_CZ.mo
Binary file not shown.
Binary file removed lang/tribe-common-da_DK.mo
Binary file not shown.
Binary file removed lang/tribe-common-de_DE.mo
Binary file not shown.
Binary file removed lang/tribe-common-el.mo
Binary file not shown.
Binary file removed lang/tribe-common-en_GB.mo
Binary file not shown.
Binary file removed lang/tribe-common-es_ES.mo
Binary file not shown.
Binary file removed lang/tribe-common-et.mo
Binary file not shown.
Binary file removed lang/tribe-common-fi.mo
Binary file not shown.
Binary file removed lang/tribe-common-fr_CA.mo
Binary file not shown.
Binary file removed lang/tribe-common-fr_FR.mo
Binary file not shown.
Binary file removed lang/tribe-common-hu_HU.mo
Binary file not shown.
Binary file removed lang/tribe-common-id_ID.mo
Binary file not shown.
Binary file removed lang/tribe-common-is_IS.mo
Binary file not shown.
Binary file removed lang/tribe-common-it_IT.mo
Binary file not shown.
Binary file removed lang/tribe-common-ja.mo
Binary file not shown.
Binary file removed lang/tribe-common-lt_LT.mo
Binary file not shown.
Binary file removed lang/tribe-common-lv.mo
Binary file not shown.
Binary file removed lang/tribe-common-nb_NO.mo
Binary file not shown.
Binary file removed lang/tribe-common-nl_NL.mo
Binary file not shown.
Binary file removed lang/tribe-common-pl_PL.mo
Binary file not shown.
Binary file removed lang/tribe-common-pt_BR.mo
Binary file not shown.
Binary file removed lang/tribe-common-pt_PT.mo
Binary file not shown.
Binary file removed lang/tribe-common-ro_RO.mo
Binary file not shown.
Binary file removed lang/tribe-common-ru_RU.mo
Binary file not shown.
Binary file removed lang/tribe-common-sk_SK.mo
Binary file not shown.
Binary file removed lang/tribe-common-sl_SI.mo
Binary file not shown.
Binary file removed lang/tribe-common-sr_RS.mo
Binary file not shown.
Binary file removed lang/tribe-common-sv_SE.mo
Binary file not shown.
Binary file removed lang/tribe-common-tr_TR.mo
Binary file not shown.
Binary file removed lang/tribe-common-zh_CN.mo
Binary file not shown.
Binary file removed lang/tribe-common-zh_TW.mo
Binary file not shown.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "tribe-common",
"version": "4.11.3",
"version": "4.11.4",
"repository": "git@github.com:moderntribe/tribe-common.git",
"_resourcepath": "src/resources",
"_domainPath": "lang",
Expand Down
8 changes: 8 additions & 0 deletions readme.txt
Expand Up @@ -2,13 +2,21 @@

== Changelog ==

= [TBD] TBD =

* Added context to the country and the state of Georgia to allow separate translation [BTRIA-63]

* Fix - Increase range of actions that trigger changes on Promoter with a `WP_Post` instance or using an ID. [TCMN-47]

= [4.11.3] 2020-02-26 =

* Fix - JavaScript error in tribe dialog when there are no dialogs. Change fallback from object to array. [TCMN-34]
* Fix - Fix display of Dialogs in Safari 12 mobile. [ETP-155]
* Fix - Bring back the dialog icons. [ETP-155]
* Tweak - Add theme compatibility for the tribe dialog [ETP-156]

* Tweak - Add check if in `the_content` filter to prevent it from being called again. [ECP-345]

= [4.11.2.1] 2020-02-25 =

* Fix - Plugin dependency registration with `Plugin_Register` will not prevent loading of all plugins in list if the last loaded fails. [TCMN-41]
Expand Down
4 changes: 2 additions & 2 deletions src/Tribe/Languages/Locations.php
Expand Up @@ -135,7 +135,7 @@ public function build_country_array() {
'TF' => esc_html__( 'French Southern Territories', 'tribe-common' ),
'GA' => esc_html__( 'Gabon', 'tribe-common' ),
'GM' => esc_html__( 'Gambia', 'tribe-common' ),
'GE' => esc_html__( 'Georgia', 'tribe-common' ),
'GE' => esc_html_x( 'Georgia', 'The country', 'tribe-common' ),
'DE' => esc_html__( 'Germany', 'tribe-common' ),
'GH' => esc_html__( 'Ghana', 'tribe-common' ),
'GI' => esc_html__( 'Gibraltar', 'tribe-common' ),
Expand Down Expand Up @@ -331,7 +331,7 @@ public function build_us_states_array() {
'DE' => esc_html__( 'Delaware', 'tribe-common' ),
'DC' => esc_html__( 'District of Columbia', 'tribe-common' ),
'FL' => esc_html__( 'Florida', 'tribe-common' ),
'GA' => esc_html__( 'Georgia', 'tribe-common' ),
'GA' => esc_html_x( 'Georgia', 'The US state Georgia','tribe-common' ),
'HI' => esc_html__( 'Hawaii', 'tribe-common' ),
'ID' => esc_html__( 'Idaho', 'tribe-common' ),
'IL' => esc_html__( 'Illinois', 'tribe-common' ),
Expand Down
2 changes: 1 addition & 1 deletion src/Tribe/Log/File_Logger.php
Expand Up @@ -27,7 +27,7 @@ protected function set_log_dir() {
*
* @var string $log_dir
*/
$this->log_dir = apply_filters( 'tribe_file_logger_directory', sys_get_temp_dir() );
$this->log_dir = apply_filters( 'tribe_file_logger_directory', get_temp_dir() );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Tribe/Main.php
Expand Up @@ -17,7 +17,7 @@ class Tribe__Main {
const OPTIONNAME = 'tribe_events_calendar_options';
const OPTIONNAMENETWORK = 'tribe_events_calendar_network_options';

const VERSION = '4.11.3';
const VERSION = '4.11.4';

const FEED_URL = 'https://theeventscalendar.com/feed/';

Expand Down
2 changes: 1 addition & 1 deletion src/Tribe/Promoter/Connector.php
Expand Up @@ -192,7 +192,7 @@ public function notify_promoter_of_changes( $post_id ) {

$payload = [
'licenseKey' => $license_key,
'sourceId' => $post_id,
'sourceId' => $post_id instanceof WP_Post ? $post_id->ID : $post_id,
];

$token = \Firebase\JWT\JWT::encode( $payload, $secret_key );
Expand Down
19 changes: 11 additions & 8 deletions src/functions/template-tags/post.php
Expand Up @@ -30,14 +30,17 @@ function tribe_get_the_content( $more_link_text = null, $strip_teaser = false, $
$content = get_the_content( $more_link_text, $strip_teaser );
}

/**
* Filters the post content.
*
* @since 0.71 of WordPress
*
* @param string $content Content of the current post.
*/
$content = apply_filters( 'the_content', $content );
if ( ! doing_filter( 'the_content' ) ) {
/**
* Filters the post content.
*
* @since 0.71 of WordPress
*
* @param string $content Content of the current post.
*/
$content = apply_filters( 'the_content', $content );
}

$content = str_replace( ']]>', ']]>', $content );

$post = $previous_post;
Expand Down
1 change: 0 additions & 1 deletion src/resources/js/admin-date-preview.min.js

This file was deleted.

1 change: 0 additions & 1 deletion src/resources/js/admin-log-controls.min.js

This file was deleted.

1 change: 0 additions & 1 deletion src/resources/js/app-shop.min.js

This file was deleted.

1 change: 0 additions & 1 deletion src/resources/js/bumpdown.min.js

This file was deleted.

1 change: 0 additions & 1 deletion src/resources/js/buttonset.min.js

This file was deleted.

1 change: 0 additions & 1 deletion src/resources/js/dependency.min.js

This file was deleted.