Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace `sys_get_temp_dir` with native `get_temp_dir` #1315

Merged
merged 2 commits into from Mar 9, 2020

Conversation

@mitogh
Copy link
Member

mitogh commented Mar 7, 2020

There are several benefits in doing the change like:

  • Use of constant to define the value WP_TEMP_DIR
  • get_temp_dir fallback to sys_get_temp_dir when the function exists and check the function is present on the system
  • Validations of the different directories (is writtable) before returning the value

In order to provide better support with native WordPress functions,

There are several benefits in doing the change like:

- Use of constant to define the value `WP_TEMP_DIR`
- `get_temp_dir` fallback to `sys_get_temp_dir` when the function exists and check the function is present on the system
- Validations of the different directories (is writtable) before returning the value

In order to provide better support with native WordPress functions,
@mitogh mitogh self-assigned this Mar 7, 2020
@mitogh mitogh added the code review label Mar 7, 2020
@mitogh mitogh merged commit ae78345 into release/B20.03 Mar 9, 2020
2 checks passed
2 checks passed
phpcs
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mitogh mitogh deleted the spotfix/tmp_directory branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.