From 8104e0494a692d6d16248db1d602d29fc3d73d7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:00:56 +0100 Subject: [PATCH 1/7] update CI task names --- .github/workflows/lint.yml | 2 +- .github/workflows/verify-browser.yml | 4 ++-- .github/workflows/verify-node.yml | 4 ++-- .github/workflows/verify-windows.yml | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 074e70e5c..5ed40efe7 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -8,7 +8,7 @@ env: jobs: verify-linux: timeout-minutes: 30 - name: Verify linux + name: Lint runs-on: ubuntu-latest strategy: matrix: diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index f84b1fb1e..2202903c8 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -1,4 +1,4 @@ -name: Verify Browser +name: Browser tests on: pull_request @@ -8,7 +8,7 @@ env: jobs: verify-linux: timeout-minutes: 30 - name: Verify linux + name: Browser tests runs-on: ubuntu-latest strategy: matrix: diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 68feb73cd..452f9dcf0 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -1,4 +1,4 @@ -name: Verify Node +name: Node tests on: pull_request @@ -8,7 +8,7 @@ env: jobs: verify-linux: timeout-minutes: 30 - name: Verify linux + name: Node tests runs-on: ubuntu-latest strategy: matrix: diff --git a/.github/workflows/verify-windows.yml b/.github/workflows/verify-windows.yml index b8f54bc1c..dac9c9e02 100644 --- a/.github/workflows/verify-windows.yml +++ b/.github/workflows/verify-windows.yml @@ -1,11 +1,11 @@ -name: Verify Windows +name: Windows tests on: pull_request jobs: verify-windows: timeout-minutes: 30 - name: Verify windows + name: Windows tests runs-on: windows-2022 steps: - name: Set git to use LF From b3df70d614bfab855f9e9016610a1d54d6eec1f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:02:29 +0100 Subject: [PATCH 2/7] update node versions in CI tasks --- .github/workflows/lint.yml | 10 +++------- .github/workflows/release.yml | 2 +- .github/workflows/verify-browser.yml | 8 ++------ .github/workflows/verify-node.yml | 3 ++- .github/workflows/verify-windows.yml | 4 ++-- 5 files changed, 10 insertions(+), 17 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5ed40efe7..622be6532 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -10,24 +10,20 @@ jobs: timeout-minutes: 30 name: Lint runs-on: ubuntu-latest - strategy: - matrix: - node-version: - - '18' steps: - uses: actions/checkout@v3 - - name: Setup Node ${{ matrix.node-version }} + - name: Setup Node 20 uses: actions/setup-node@v3 env: FORCE_COLOR: 0 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: npm - name: Install Dependencies run: npm ci - name: Lint - run: npm run lint \ No newline at end of file + run: npm run lint diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e43faeeaf..f330de9c1 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -24,7 +24,7 @@ jobs: env: FORCE_COLOR: 0 with: - node-version: '18' + node-version: '20' cache: 'npm' registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index 2202903c8..54a4665c2 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -10,20 +10,16 @@ jobs: timeout-minutes: 30 name: Browser tests runs-on: ubuntu-latest - strategy: - matrix: - node-version: - - '18' steps: - uses: actions/checkout@v3 - - name: Setup Node ${{ matrix.node-version }} + - name: Setup Node 20 uses: actions/setup-node@v3 env: FORCE_COLOR: 0 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: npm - name: Install Dependencies diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 452f9dcf0..557ed0276 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -14,7 +14,8 @@ jobs: matrix: node-version: - '18' - - '19' + - '20' + - 'latest' steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/verify-windows.yml b/.github/workflows/verify-windows.yml index dac9c9e02..9fcb54cb5 100644 --- a/.github/workflows/verify-windows.yml +++ b/.github/workflows/verify-windows.yml @@ -15,12 +15,12 @@ jobs: - uses: actions/checkout@v3 - - name: Setup Node '18' + - name: Setup Node '20' uses: actions/setup-node@v3 env: FORCE_COLOR: 0 with: - node-version: '18' + node-version: '20' cache: 'npm' - name: Install Playwright dependencies From 6d3ec35d0a0958bfd749e32515efa16b29e49cc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:02:48 +0100 Subject: [PATCH 3/7] update actions packages --- .github/workflows/lint.yml | 4 ++-- .github/workflows/release.yml | 4 ++-- .github/workflows/verify-browser.yml | 4 ++-- .github/workflows/verify-node.yml | 4 ++-- .github/workflows/verify-windows.yml | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 622be6532..0bc74322c 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -12,10 +12,10 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node 20 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f330de9c1..e8ae03eec 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -14,13 +14,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits fetch-depth: 0 - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index 54a4665c2..9c165ffd3 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -12,10 +12,10 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node 20 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 557ed0276..000ce8f41 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -18,10 +18,10 @@ jobs: - 'latest' steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: diff --git a/.github/workflows/verify-windows.yml b/.github/workflows/verify-windows.yml index 9fcb54cb5..d26c97c5f 100644 --- a/.github/workflows/verify-windows.yml +++ b/.github/workflows/verify-windows.yml @@ -13,10 +13,10 @@ jobs: git config --global core.autocrlf false git config --global core.eol lf - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup Node '20' - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: From da71b4d0bf38206a5e263f365d7dcfe853e9bece Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:32:31 +0100 Subject: [PATCH 4/7] update more actions actions --- .github/workflows/canary.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 4a4949319..4339c70aa 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -15,13 +15,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Repo - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits fetch-depth: 0 - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 env: FORCE_COLOR: 0 with: From 6d011188f9964cadebda5cbbea2cdc24eeeaa076 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:32:47 +0100 Subject: [PATCH 5/7] update a node version --- .github/workflows/canary.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 4339c70aa..01a04f902 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -25,7 +25,7 @@ jobs: env: FORCE_COLOR: 0 with: - node-version: '18' + node-version: '20' cache: 'npm' registry-url: 'https://registry.npmjs.org' From f7a5aaaa02b791ee9e79c42d710b3a4893514f0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:32:59 +0100 Subject: [PATCH 6/7] update job names --- .github/workflows/lint.yml | 4 ++-- .github/workflows/verify-browser.yml | 2 +- .github/workflows/verify-node.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0bc74322c..7aae921cd 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -6,9 +6,9 @@ env: FORCE_COLOR: true jobs: - verify-linux: + linux: timeout-minutes: 30 - name: Lint + name: Linux runs-on: ubuntu-latest steps: diff --git a/.github/workflows/verify-browser.yml b/.github/workflows/verify-browser.yml index 9c165ffd3..8b6b2ba22 100644 --- a/.github/workflows/verify-browser.yml +++ b/.github/workflows/verify-browser.yml @@ -8,7 +8,7 @@ env: jobs: verify-linux: timeout-minutes: 30 - name: Browser tests + name: Linux runs-on: ubuntu-latest steps: diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index 000ce8f41..e526afd1a 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -8,7 +8,7 @@ env: jobs: verify-linux: timeout-minutes: 30 - name: Node tests + name: Linux runs-on: ubuntu-latest strategy: matrix: From d3e54f652e13381a0d71d12fd8e961cfef4bbad7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristj=C3=A1n=20Oddsson?= Date: Fri, 5 Jan 2024 11:33:15 +0100 Subject: [PATCH 7/7] move windows tests into node test file --- .github/workflows/verify-node.yml | 39 +++++++++++++++++++++++++ .github/workflows/verify-windows.yml | 43 ---------------------------- 2 files changed, 39 insertions(+), 43 deletions(-) delete mode 100644 .github/workflows/verify-windows.yml diff --git a/.github/workflows/verify-node.yml b/.github/workflows/verify-node.yml index e526afd1a..13853e7c2 100644 --- a/.github/workflows/verify-node.yml +++ b/.github/workflows/verify-node.yml @@ -49,3 +49,42 @@ jobs: - name: Test run: npm run test:node + + verify-windows: + timeout-minutes: 30 + name: Windows + runs-on: windows-2022 + steps: + - name: Set git to use LF + run: | + git config --global core.autocrlf false + git config --global core.eol lf + + - uses: actions/checkout@v4 + + - name: Setup Node '20' + uses: actions/setup-node@v4 + env: + FORCE_COLOR: 0 + with: + node-version: '20' + cache: 'npm' + + - name: Install Playwright dependencies + run: npx playwright install-deps + + # Set up GitHub Actions caching for Wireit. + - uses: google/wireit@setup-github-actions-caching/v1 + + - name: Install Dependencies + run: npm ci + + - name: Build + run: npm run build + + # build for production in CI to make sure tests can run with production build + - name: Build specific packages for production + run: npm run build:production + + - name: Test + run: npm run test:node diff --git a/.github/workflows/verify-windows.yml b/.github/workflows/verify-windows.yml deleted file mode 100644 index d26c97c5f..000000000 --- a/.github/workflows/verify-windows.yml +++ /dev/null @@ -1,43 +0,0 @@ -name: Windows tests - -on: pull_request - -jobs: - verify-windows: - timeout-minutes: 30 - name: Windows tests - runs-on: windows-2022 - steps: - - name: Set git to use LF - run: | - git config --global core.autocrlf false - git config --global core.eol lf - - - uses: actions/checkout@v4 - - - name: Setup Node '20' - uses: actions/setup-node@v4 - env: - FORCE_COLOR: 0 - with: - node-version: '20' - cache: 'npm' - - - name: Install Playwright dependencies - run: npx playwright install-deps - - # Set up GitHub Actions caching for Wireit. - - uses: google/wireit@setup-github-actions-caching/v1 - - - name: Install Dependencies - run: npm ci - - - name: Build - run: npm run build - - # build for production in CI to make sure tests can run with production build - - name: Build specific packages for production - run: npm run build:production - - - name: Test - run: npm run test:node