Skip to content

more miscellaneous writer cleanup/testing #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2025
Merged

more miscellaneous writer cleanup/testing #222

merged 10 commits into from
Oct 23, 2025

Conversation

@wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 23, 2025 •
edited
Loading

  • tidy up converter logic
  • fix inset in array macro
  • default oc period data arrays to None
  • clarify temporary oc special casing
  • no need for Solution slnfname field
  • add strict arg to Component.to_dict
  • drop duplicate filename in Simulation
  • move maxbound fn to utils module
  • add some docstrings
  • add test assertions

@wpbonelli wpbonelli added requirement Core requirement IO Related to loading/writing input/output files labels Oct 23, 2025
@wpbonelli wpbonelli added this to the Demo milestone Oct 23, 2025
@wpbonelli wpbonelli marked this pull request as ready for review October 23, 2025 22:44
@wpbonelli wpbonelli merged commit 6d04683 into modflowpy:develop Oct 23, 2025
10 of 11 checks passed
@wpbonelli wpbonelli deleted the more branch October 23, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

IO Related to loading/writing input/output files requirement Core requirement

Projects

None yet

Milestone

Demo

Development

Successfully merging this pull request may close these issues.

1 participant

@wpbonelli