Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change __constructor__ to return a QueryCompiler instead of a View object. #295

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@devin-petersohn
Copy link
Member

commented Dec 10, 2018

What do these changes do?

Returns a new QueryCompiler object instead of a View when performing operations on the View. The previous problem presented itself when operations resulted in changes in the underlying structure.

Related issue number

Resolves #147

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

devin-petersohn added some commits Dec 10, 2018

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/170/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/108/
Test PASSed.

@simon-mo
Copy link
Collaborator

left a comment

Thanks Devin! This is a good hack. A re-write is still needed to address all weird issue around iloc and view and blocks.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/171/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 10, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/109/
Test PASSed.

@devin-petersohn devin-petersohn merged commit dc1a88f into modin-project:master Dec 11, 2018

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.