Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dtypes to the `exclude` parameter in the remote partition #321

Merged
merged 2 commits into from Dec 25, 2018

Conversation

Projects
None yet
2 participants
@devin-petersohn
Copy link
Member

commented Dec 25, 2018

What do these changes do?

  • This will give the correct result when df.describe is called
  • Fixes an index mismatch error between the remote and local

Related issue number

Resolves #320

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

devin-petersohn added some commits Dec 25, 2018

Adding dtypes to the `exclude` parameter in the remote partition
* This will give the correct result when `df.describe` is called
* Fixes an index mismatch error between the remote and local
@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 25, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 25, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/139/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 25, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Dec 25, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/201/
Test PASSed.

@devin-petersohn devin-petersohn merged commit f4b44f8 into modin-project:master Dec 25, 2018

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.