Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handling empty DataFrames for selective operations #369

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@devin-petersohn
Copy link
Member

commented Jan 4, 2019

  • Adding a condition for selective apply operations that will simply
    return an empty 2D numpy array for partitions if there are no
    partitions.
  • This is added to both apply_func_to_select_indices and
    apply_func_to_select_indices_along_full_axis

What do these changes do?

Related issue number

Resolves #368

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/
Correctly handling empty DataFrames for selective operations
* Adding a condition for selective apply operations that will simply
  return an empty 2D numpy array for partitions if there are no
  partitions.
* This is added to both `apply_func_to_select_indices` and
  `apply_func_to_select_indices_along_full_axis`
@AmplabJenkins

This comment has been minimized.

Copy link

commented Jan 4, 2019

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Jan 4, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/223/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Jan 4, 2019

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Jan 4, 2019

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/284/
Test PASSed.

@devin-petersohn devin-petersohn merged commit 06726fb into modin-project:master Jan 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.