align read_excel() signature with pandas 0.23.4 #415
Conversation
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
this also solves python 2 support build failure
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
modin/engines/base/io.py
Outdated
| "convert_float": convert_float, | ||
| "converters": converters, | ||
| "dtype": dtype, | ||
| "true_values": true_values, | ||
| "false_values": false_values, | ||
| "engine": engine, | ||
| "squeeze": squeeze, | ||
| "skipfooter": skipfooter, | ||
| "kwds": kwds, |
There was a problem hiding this comment.
I think we need to do an update instead of setting kwds=kwds here. It will treat kwds as a keyword if we do it this way.
kwargs = {...}
kwargs.update(kwds)
return cls.from_pandas(...)There was a problem hiding this comment.
You are correct, this makes much more sense. I also added an update statement one level up at pandas/io since we pack everything into kwargs as well . This would prevent the same issue of kwds having a kwds keyword while sticking to the original signatures
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
What do these changes do?
Aligning read_excel signature with pandas 0.23.4
Related issue number
#414
git diff upstream/master -u -- "*.py" | flake8 --diffblack --check modin/