Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct support for `include="all"` #486

Merged
merged 5 commits into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@devin-petersohn
Copy link
Member

commented Mar 1, 2019

  • Resolves $484
  • Adds correct support for all include values passed
    • Previously, the behavior was to use include to compute exclude
    • The correct behavior is that include is strictly inclusive, such
      that only types in the include list are included, rather than
      those being included in addition to the default types.
  • Also correctly throws the same error type as pandas (with the same
    message, though the message is not informative
  • Add tests for include="all" and include=[np.timedelta64, np.datetime64, np.object, np.bool]

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

devin-petersohn added some commits Mar 1, 2019

Add correct support for `include="all"`
* Resolves $484
* Adds correct support for all `include` values passed
  * Previously, the behavior was to use `include` to compute `exclude`
  * The correct behavior is that `include` is strictly inclusive, such
    that only types in the `include` list are included, rather than
    those being included in addition to the default types.
* Also correctly throws the same error type as pandas (with the same
  message, though the message is not informative
* Add tests for `include="all"` and `include=[np.timedelta64, np.datetime64, np.object, np.bool]`
@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 1, 2019

Merged build finished. Test FAILed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 1, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/573/
Test FAILed.

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2019

Codecov Report

Merging #486 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage    87.7%   87.98%   +0.28%     
==========================================
  Files          34       34              
  Lines        4757     4760       +3     
==========================================
+ Hits         4172     4188      +16     
+ Misses        585      572      -13
Impacted Files Coverage Δ
modin/pandas/dataframe.py 88.93% <100%> (+0.48%) ⬆️
...management/query_compiler/pandas_query_compiler.py 88.01% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a7a27...db9382b. Read the comment docs.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 2, 2019

Merged build finished. Test FAILed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 2, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/576/
Test FAILed.

devin-petersohn added some commits Mar 2, 2019

@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 2, 2019

Merged build finished. Test FAILed.

@AmplabJenkins

This comment has been minimized.

Copy link

commented Mar 2, 2019

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/578/
Test FAILed.

@devin-petersohn devin-petersohn merged commit 3402314 into modin-project:master Mar 2, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 87.7%)
Details
codecov/project 87.98% (+0.28%) compared to 50a7a27
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.