Fix reset_index when name field of the index is set
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves modin-project#186 * Corrects the previous behavior by setting the name of the new column to the name of the index * Add tests to verify the behavior
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 37 37
Lines 5429 5429
==========================================
+ Hits 4899 4900 +1
+ Misses 530 529 -1
Continue to review full report at Codecov.
|
williamma12
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Looks good @devin-petersohn! Lets wait for the tests to pass before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the name of the index
What do these changes do?
Related issue number
flake8 modinblack --check modin