Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6194: Fix crashes on groupby.{pct_change,diff} #6195

Merged
merged 3 commits into from May 24, 2023

Conversation

noloerino
Copy link
Collaborator

@noloerino noloerino commented May 23, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Modin crashes on groupby.{pct_change,diff} #6194
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
@noloerino noloerino requested a review from a team as a code owner May 23, 2023 21:37
@noloerino noloerino changed the title FIX: Fix crashes on groupby.{pct_change,diff} #6194 FIX-#6194: Fix crashes on groupby.{pct_change,diff} May 23, 2023
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noloerino I guess the lines you're fixing were never tested? Can we make a test case that tests them?

@noloerino
Copy link
Collaborator Author

Copy link
Collaborator

@RehanSD RehanSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvashishtha mvashishtha merged commit 646d0da into modin-project:master May 24, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Modin crashes on groupby.{pct_change,diff}
3 participants