Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous teardown module for parquet #648

Conversation

@williamma12
Copy link
Collaborator

commented Jun 4, 2019

What do these changes do?

Remove extraneous teardown module

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          37       37           
  Lines        5597     5597           
=======================================
  Hits         5065     5065           
  Misses        532      532

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8978e1c...3eb9482. Read the comment docs.

@devin-petersohn
Copy link
Member

left a comment

Instead of removing we should probably be using it.

For all the parquet tests we don't teardown.

@williamma12

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 4, 2019

This is just a codeblock that I forgot to delete when updating the parquet test to use pytest fixtures. We tear down here

# Delete parquet file that was created
if os.path.exists(TEST_PARQUET_FILENAME):
if os.path.isdir(TEST_PARQUET_FILENAME):
shutil.rmtree(TEST_PARQUET_FILENAME)
else:
os.remove(TEST_PARQUET_FILENAME)

@devin-petersohn devin-petersohn merged commit d5c2f2b into modin-project:master Jun 4, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing 8978e1c...3eb9482
Details
codecov/project 90.49% remains the same compared to 8978e1c
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.