Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes full axis reduce functions with empty row and/or column partitions #663

Merged
merged 7 commits into from Jun 11, 2019

Conversation

@williamma12
Copy link
Collaborator

commented Jun 10, 2019

What do these changes do?

Fixes bug that arises when entire rows/columns are empty in doing full_axis_reductions

Related issue number

Fixes #646

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
@codecov

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #663 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #663      +/-   ##
=========================================
+ Coverage   90.49%   90.5%   +<.01%     
=========================================
  Files          37      37              
  Lines        5610    5613       +3     
=========================================
+ Hits         5077    5080       +3     
  Misses        533     533
Impacted Files Coverage Δ
modin/pandas/series.py 91.52% <ø> (ø) ⬆️
modin/backends/pandas/query_compiler.py 92.24% <100%> (-0.08%) ⬇️
modin/engines/base/frame/partition_manager.py 80.3% <100%> (ø) ⬆️
modin/pandas/dataframe.py 89.8% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f34ce3...2bf63d9. Read the comment docs.

@williamma12 williamma12 referenced this pull request Jun 10, 2019
3 of 3 tasks complete

williamma12 added some commits Jun 10, 2019

@devin-petersohn devin-petersohn merged commit 70e56c0 into modin-project:master Jun 11, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 90.49%)
Details
codecov/project 90.5% (+<.01%) compared to 8f34ce3
Details
@devin-petersohn

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Great fix, thanks @williamma12!

@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.