Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary operations after transpose #676

Merged
merged 1 commit into from Jun 16, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 16, 2019

What do these changes do?

  • Resolves #675
  • Adds some logic on how to handle the transpose case when left is
    transposed
  • If right is transposed, internally that case is already handled.

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix binary operations after transpose
* Resolves #675
* Adds some logic on how to handle the `transpose` case when left is
  transposed
* If right is transposed, internally that case is already handled.
@codecov

This comment has been minimized.

Copy link

commented Jun 16, 2019

Codecov Report

Merging #676 into master will decrease coverage by 20.24%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #676       +/-   ##
===========================================
- Coverage   90.49%   70.24%   -20.25%     
===========================================
  Files          37       37               
  Lines        5658     5660        +2     
===========================================
- Hits         5120     3976     -1144     
- Misses        538     1684     +1146
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 63.21% <50%> (-29.01%) ⬇️
...engines/python/pandas_on_python/frame/partition.py 34.48% <0%> (-58.63%) ⬇️
modin/pandas/dataframe.py 34.63% <0%> (-54.89%) ⬇️
modin/engines/base/frame/axis_partition.py 45.45% <0%> (-47.73%) ⬇️
modin/data_management/utils.py 46.51% <0%> (-37.21%) ⬇️
...python/pandas_on_python/frame/partition_manager.py 63.15% <0%> (-36.85%) ⬇️
modin/pandas/base.py 70.4% <0%> (-24.51%) ⬇️
modin/pandas/indexing.py 57.29% <0%> (-23.44%) ⬇️
modin/engines/base/io.py 75.96% <0%> (-20.2%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bec6c5...18371d2. Read the comment docs.

@williamma12
Copy link
Collaborator

left a comment

Looks good, @devin-petersohn !

@williamma12 williamma12 merged commit 45f4b49 into modin-project:master Jun 16, 2019

1 of 3 checks passed

codecov/patch 50% of diff hit (target 90.49%)
Details
codecov/project 70.24% (-20.25%) compared to 6bec6c5
Details
Travis CI - Pull Request Build Passed
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.