Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with `sort_values` after transpose #679

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 16, 2019

  • Resolves #677
  • Also add logic to handle update_inplace with transposed QueryCompiler
  • Resolves #678

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
@codecov

This comment has been minimized.

Copy link

commented Jun 16, 2019

Codecov Report

Merging #679 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
- Coverage   90.47%   90.46%   -0.02%     
==========================================
  Files          37       37              
  Lines        5660     5662       +2     
==========================================
+ Hits         5121     5122       +1     
- Misses        539      540       +1
Impacted Files Coverage Δ
modin/pandas/series.py 91.52% <100%> (ø) ⬆️
modin/backends/pandas/query_compiler.py 92.06% <50%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f4b49...21c73fc. Read the comment docs.

devin-petersohn added some commits Jun 16, 2019

Fix issue with `sort_values` after transpose
* Resolves #677
* Also add logic to handle update_inplace with transposed QueryCompiler
* Resolves #678

@devin-petersohn devin-petersohn force-pushed the devin-petersohn:issues/677 branch from 7a31ee8 to 21c73fc Jun 16, 2019

@williamma12
Copy link
Collaborator

left a comment

Looks good @devin-petersohn !

@williamma12 williamma12 merged commit 9a5fb8f into modin-project:master Jun 17, 2019

1 of 3 checks passed

codecov/patch 66.66% of diff hit (target 90.47%)
Details
codecov/project 90.46% (-0.02%) compared to 45f4b49
Details
Travis CI - Pull Request Build Passed
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.