Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `concat` when QueryCompiler is transposed #681

Merged
merged 2 commits into from Jun 17, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 16, 2019

  • Resolves #680
  • Adds a condition similar to other transpose handling that changes the
    axis

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix `concat` when QueryCompiler is transposed
* Resolves #680
* Adds a condition similar to other transpose handling that changes the
  axis
@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #681 into master will decrease coverage by 4.67%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #681      +/-   ##
=========================================
- Coverage   90.47%   85.8%   -4.68%     
=========================================
  Files          37      37              
  Lines        5660    5664       +4     
=========================================
- Hits         5121    4860     -261     
- Misses        539     804     +265
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 78.17% <50%> (-13.97%) ⬇️
...engines/python/pandas_on_python/frame/partition.py 34.48% <0%> (-58.63%) ⬇️
...python/pandas_on_python/frame/partition_manager.py 63.15% <0%> (-36.85%) ⬇️
modin/engines/base/frame/axis_partition.py 72.72% <0%> (-20.46%) ⬇️
modin/engines/base/io.py 75.96% <0%> (-20.2%) ⬇️
...es/python/pandas_on_python/frame/axis_partition.py 82.35% <0%> (-17.65%) ⬇️
modin/data_management/utils.py 72.09% <0%> (-11.63%) ⬇️
modin/data_management/factories.py 86.11% <0%> (-8.34%) ⬇️
modin/engines/ray/utils.py 78.57% <0%> (-7.15%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f4b49...6b7f99f. Read the comment docs.

@williamma12 williamma12 merged commit c9a3b8c into modin-project:master Jun 17, 2019

1 check failed

Travis CI - Pull Request Build Errored
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.