Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `concat` with all Series and axis=1 #684

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 18, 2019

  • Resolves #683
  • Adds logic to handle edge case where keys is not None and all objects
    are Series.

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix `concat` with all Series and axis=1
* Resolves #683
* Adds logic to handle edge case where keys is not None and all objects
  are Series.
@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #684 into master will decrease coverage by 12.7%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #684       +/-   ##
===========================================
- Coverage   90.44%   77.74%   -12.71%     
===========================================
  Files          37       37               
  Lines        5664     5666        +2     
===========================================
- Hits         5123     4405      -718     
- Misses        541     1261      +720
Impacted Files Coverage Δ
modin/pandas/concat.py 84.78% <83.33%> (-1.59%) ⬇️
...engines/python/pandas_on_python/frame/partition.py 34.48% <0%> (-58.63%) ⬇️
modin/engines/base/frame/axis_partition.py 45.45% <0%> (-47.73%) ⬇️
modin/data_management/utils.py 46.51% <0%> (-37.21%) ⬇️
...python/pandas_on_python/frame/partition_manager.py 63.15% <0%> (-36.85%) ⬇️
modin/pandas/indexing.py 57.29% <0%> (-23.44%) ⬇️
modin/pandas/dataframe.py 66.48% <0%> (-23.05%) ⬇️
modin/backends/pandas/query_compiler.py 69.88% <0%> (-22.1%) ⬇️
modin/engines/base/io.py 75.96% <0%> (-20.2%) ⬇️
...es/python/pandas_on_python/frame/axis_partition.py 82.35% <0%> (-17.65%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3b8c...7edc652. Read the comment docs.

@williamma12
Copy link
Collaborator

left a comment

Looks good @devin-petersohn !

@williamma12 williamma12 merged commit 2441611 into modin-project:master Jun 18, 2019

1 of 3 checks passed

codecov/patch 83.33% of diff hit (target 90.44%)
Details
codecov/project 77.74% (-12.71%) compared to c9a3b8c
Details
Travis CI - Pull Request Build Passed
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.