Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtypes on empty dataframes calls to to_pandas #688

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@williamma12
Copy link
Collaborator

commented Jun 18, 2019

What do these changes do?

Checks to make sure that the calls are not empty

Related issue number

Resolves #685

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #688 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   90.44%   90.39%   -0.06%     
==========================================
  Files          37       37              
  Lines        5664     5682      +18     
==========================================
+ Hits         5123     5136      +13     
- Misses        541      546       +5
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 91.91% <66.66%> (-0.08%) ⬇️
modin/pandas/concat.py 82% <0%> (-4.37%) ⬇️
...din/engines/ray/generic/frame/partition_manager.py 95.23% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3b8c...cfbaf9d. Read the comment docs.

Resolve comments
Co-Authored-By: Devin Petersohn <devin-petersohn@users.noreply.github.com>

@devin-petersohn devin-petersohn added this to the 0.5.3 milestone Jun 18, 2019

@devin-petersohn devin-petersohn merged commit 0a59a85 into modin-project:master Jun 18, 2019

1 of 3 checks passed

codecov/patch 66.66% of diff hit (target 90.44%)
Details
codecov/project 90.39% (-0.06%) compared to c9a3b8c
Details
Travis CI - Pull Request Build Passed
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.