Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to pandas when trying to get slice from Series #689

merged 2 commits into from Jun 18, 2019


Copy link

commented Jun 18, 2019

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #689 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
- Coverage   90.44%   90.43%   -0.02%     
  Files          37       37              
  Lines        5664     5666       +2     
+ Hits         5123     5124       +1     
- Misses        541      542       +1
Impacted Files Coverage Δ
modin/pandas/ 91.38% <50%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3b8c...da5bc32. Read the comment docs.

@devin-petersohn devin-petersohn added this to the 0.5.3 milestone Jun 18, 2019

Copy link

left a comment

Looks good, @devin-petersohn !

@williamma12 williamma12 merged commit ce2a48b into modin-project:master Jun 18, 2019

1 check failed

Travis CI - Pull Request Build Errored

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.