Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal indices calculation for non-compute partitions #691

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 18, 2019

  • Resolves #690
  • Previously we were always triggering computation on the first
    partition, but now we filter it out if there is nothing to compute.

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix internal indices calculation for non-compute partitions
* Resolves #690
* Previously we were always triggering computation on the first
  partition, but now we filter it out if there is nothing to compute.
@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #691 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #691      +/-   ##
=========================================
- Coverage   90.44%   90.4%   -0.05%     
=========================================
  Files          37      37              
  Lines        5664    5667       +3     
=========================================
  Hits         5123    5123              
- Misses        541     544       +3
Impacted Files Coverage Δ
modin/engines/base/frame/partition_manager.py 80.78% <100%> (+0.17%) ⬆️
modin/backends/pandas/query_compiler.py 91.71% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3b8c...f37425e. Read the comment docs.

@devin-petersohn devin-petersohn added this to the 0.5.3 milestone Jun 18, 2019

Address comment
Co-Authored-By: William Ma <12377941+williamma12@users.noreply.github.com>
@williamma12
Copy link
Collaborator

left a comment

looks good, @devin-petersohn !

@williamma12 williamma12 merged commit baae78b into modin-project:master Jun 18, 2019

1 check failed

Travis CI - Pull Request Build Canceled
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.