Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how we compute the block_widths/lengths after single update #693

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@devin-petersohn
Copy link
Member

commented Jun 18, 2019

  • Resolves #692
  • Checks that each object is an integer for width() or length()
  • If not, calls ray.get on it.

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing
Fix how we compute the block_widths/lengths after single update
* Resolves #692
* Checks that each object is an integer for `width()` or `length()`
* If not, calls `ray.get` on it.
@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files          37       37           
  Lines        5664     5664           
=======================================
  Hits         5123     5123           
  Misses        541      541
Impacted Files Coverage Δ
...din/engines/ray/generic/frame/partition_manager.py 96.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3b8c...6b1e826. Read the comment docs.

@devin-petersohn devin-petersohn added this to the 0.5.3 milestone Jun 18, 2019

@williamma12
Copy link
Collaborator

left a comment

Looks good, @devin-petersohn !

@williamma12 williamma12 merged commit 8dde34c into modin-project:master Jun 18, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing c9a3b8c...6b1e826
Details
codecov/project 90.44% remains the same compared to c9a3b8c
Details
@modin-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This pull request has been mentioned on Modin Discuss. There might be relevant details there:

https://discuss.modin.org/t/modin-0-5-3-release-notes/66/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.