Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mode=static with CMake's BUILD_SHARED_LIBS flag #99

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@SupSuper
Copy link
Contributor

commented Aug 1, 2019

CMake already has a flag for controlling static/shared builds, so let's use that instead: https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html

Also made it an option so it's exposed to the CMake GUI and customizable by users.

SupSuper and others added some commits Aug 1, 2019

@Turupawn

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

I didn't know that flag existed! 😮 It's great to have it! 😄

@Turupawn Turupawn merged commit caa0195 into modio:master Aug 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.