Skip to content

Conversation

@robodal
Copy link
Contributor

@robodal robodal commented Dec 26, 2017

What does it do ?

Check total packages.. but created empty element of array and error in data future

Why is it needed ?

Fix for modstore.pro repository

Related issue(s)/PR(s)

fixes #186

@Mark-H
Copy link
Member

Mark-H commented Dec 27, 2017

Hi @crazy-beard - thanks for this. Could you explain why this fix works for modstore?

@robodal
Copy link
Contributor Author

robodal commented Dec 28, 2017

Modstore method by signature return correct response ($response->isError() == false), but in XML attribute total = 0.
Response don't check this condition and generate
$packages[''] = [
'name' => '',
'version' => '',
'location' => '',
'signature' => ''
];

@Mark-H Mark-H merged commit 85a20eb into modmore:master Jan 22, 2019
@hugopeek
Copy link
Contributor

I am not experiencing issues after this PR, but when editing this file now in PhpStorm, it gives me an error on line 195, saying the $foundPackages variable is not defined..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't install packages from modstore.pro

3 participants