New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deployment checks #1351

Merged
merged 3 commits into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@fyfe
Collaborator

fyfe commented Jan 12, 2018

Add a system check to ensue USE_TZ is enabled, if its not enabled errors can occur during summer/winter time transitions due to the local time occurring twice. When USE_TZ is enabled all times are stored in UTC to avoid this issue.

Fixes #1086

@fyfe fyfe added the enhancement label Jan 12, 2018

@fyfe fyfe added this to the 1.10.0 milestone Jan 12, 2018

@fyfe fyfe self-assigned this Jan 12, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jan 12, 2018

Codecov Report

Merging #1351 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   84.79%   84.79%   -0.01%     
==========================================
  Files         151      153       +2     
  Lines        7268     7280      +12     
==========================================
+ Hits         6163     6173      +10     
- Misses       1105     1107       +2

codecov bot commented Jan 12, 2018

Codecov Report

Merging #1351 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   84.79%   84.79%   -0.01%     
==========================================
  Files         151      153       +2     
  Lines        7268     7280      +12     
==========================================
+ Hits         6163     6173      +10     
- Misses       1105     1107       +2
SILENCED_SYSTEM_CHECKS = [
"security.W019", # modoboa uses iframes to display e-mails
]

This comment has been minimized.

@tonioo

tonioo Jan 12, 2018

Member

This setting is already defined in amavis defaut settings so, when this plugin is enabled, it won't work. (see https://github.com/modoboa/modoboa-amavis/blob/master/modoboa_amavis/settings.py#L7)
I think we can use something like this: https://github.com/modoboa/modoboa-contacts/blob/master/modoboa_contacts/settings.py#L15

@tonioo

tonioo Jan 12, 2018

Member

This setting is already defined in amavis defaut settings so, when this plugin is enabled, it won't work. (see https://github.com/modoboa/modoboa-amavis/blob/master/modoboa_amavis/settings.py#L7)
I think we can use something like this: https://github.com/modoboa/modoboa-contacts/blob/master/modoboa_contacts/settings.py#L15

This comment has been minimized.

@fyfe

fyfe Jan 12, 2018

Collaborator

Yeah I noticed that before, I'll submit a PR for modoboa-amavis

@fyfe

fyfe Jan 12, 2018

Collaborator

Yeah I noticed that before, I'll submit a PR for modoboa-amavis

This comment has been minimized.

@fyfe
@fyfe

fyfe Jan 12, 2018

Collaborator

This comment has been minimized.

@tonioo

tonioo Jan 12, 2018

Member

Great!

@tonioo

tonioo Jan 12, 2018

Member

Great!

Show outdated Hide outdated modoboa/core/tests/test_checks.py Outdated

fyfe added some commits Jan 9, 2018

silence security.W019 check
Modoboa uses iframes to display e-mails so X_FRAME_OPTIONS can't be set
to DENY.

@tonioo tonioo merged commit daeccd8 into modoboa:master Jan 12, 2018

3 checks passed

codecov/patch 100% of diff hit (target 70%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +15.2% compared to f8d997b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fyfe fyfe deleted the fyfe:feature/deployment-checks branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment