remove dependency on pip internals #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse - remove, now part of Pythons stdlib in Python 2.7 and 3.4+ backports.csv - only required for Python 2 ipaddress - only required for Python < 3.3
ghost
added
the
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
+ Coverage 85.41% 85.46% +0.04%
==========================================
Files 143 143
Lines 7392 7388 -4
==========================================
Hits 6314 6314
+ Misses 1078 1074 -4 |
tonioo
reviewed
Mar 22, 2018
| # bcrypt requires libffi-dev | ||
| bcrypt==3.1.4 | ||
| dnspython==1.15.0 | ||
| feedparser==5.2.1 | ||
| gevent==1.2.2 | ||
| ipaddress | ||
| ipaddress; python_version < '3.3' |
There was a problem hiding this comment.
Does it mean this package is not compatible with python >= 3.3? If so, we need a replacement...
|
Its included in python 3.3+
…On March 22, 2018 2:45:47 PM UTC, Antoine Nguyen ***@***.***> wrote:
tonioo commented on this pull request.
> # bcrypt requires libffi-dev
bcrypt==3.1.4
dnspython==1.15.0
feedparser==5.2.1
gevent==1.2.2
-ipaddress
+ipaddress; python_version < '3.3'
Does it mean this package is not compatible with python >= 3.3? If so,
we need a replacement...
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
#1439 (review)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1438