Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on pip internals #1439

Merged
merged 2 commits into from Mar 22, 2018
Merged

remove dependency on pip internals #1439

merged 2 commits into from Mar 22, 2018

Conversation

@fyfe
Copy link
Contributor

@fyfe fyfe commented Mar 19, 2018

see #1438

fyfe added 2 commits Mar 19, 2018
argparse - remove, now part of Pythons stdlib in Python 2.7 and 3.4+
backports.csv - only required for Python 2
ipaddress - only required for Python < 3.3
@fyfe fyfe added the bug label Mar 19, 2018
@fyfe fyfe added this to the 1.10.4 milestone Mar 19, 2018
@fyfe fyfe self-assigned this Mar 19, 2018
@codecov
Copy link

@codecov codecov bot commented Mar 19, 2018

Codecov Report

Merging #1439 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
+ Coverage   85.41%   85.46%   +0.04%     
==========================================
  Files         143      143              
  Lines        7392     7388       -4     
==========================================
  Hits         6314     6314              
+ Misses       1078     1074       -4
@maisim maisim mentioned this pull request Mar 20, 2018
# bcrypt requires libffi-dev
bcrypt==3.1.4
dnspython==1.15.0
feedparser==5.2.1
gevent==1.2.2
ipaddress
ipaddress; python_version < '3.3'

This comment has been minimized.

@tonioo

tonioo Mar 22, 2018
Member

Does it mean this package is not compatible with python >= 3.3? If so, we need a replacement...

@fyfe
Copy link
Contributor Author

@fyfe fyfe commented Mar 22, 2018

@tonioo tonioo merged commit 587eb77 into modoboa:master Mar 22, 2018
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 70%)
Details
codecov/project 85.46% (+0.04%) compared to 95ccae5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fyfe added a commit to fyfe/modoboa that referenced this pull request Mar 31, 2018
adding external dependencies to setup.py was a bad idea
tonioo added a commit that referenced this pull request Apr 2, 2018
 revert #1439 changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants