New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP508 markers in requirements.txt have been broken since dfabe89 #1464

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@fyfe
Copy link
Collaborator

fyfe commented Apr 12, 2018

@fyfe fyfe added the bug label Apr 12, 2018

@fyfe fyfe added this to the 1.10.5 milestone Apr 12, 2018

@fyfe fyfe self-assigned this Apr 12, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         143      143           
  Lines        7420     7420           
=======================================
  Hits         6370     6370           
  Misses       1050     1050
@kryskool
Copy link
Contributor

kryskool left a comment

ok for me

@kryskool

This comment has been minimized.

Copy link
Contributor

kryskool commented Apr 12, 2018

@fyfe thanks for the report and fix

Regards,

@kryskool kryskool merged commit f604aac into modoboa:master Apr 12, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 3b4cf12...abcb9ab
Details
codecov/project 85.84% remains the same compared to 3b4cf12
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fyfe fyfe deleted the fyfe:fix/installer-197 branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment