New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: DKIM checks fail #1648

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@jammo-nl
Copy link
Contributor

jammo-nl commented Jan 7, 2019

Description of the issue/feature this PR addresses:
The DKIM key is base64 encoded, meaning it can end with "=" signs
Split on "=" and check if you have 2 'parts' (key and value) will fail in these cases.
By using split("=",1) we make sure we only slit on the first occurence of the "=" sign
(solves #1647 and partially #1640 and #1642)

Current behavior before PR:
DKIM checks fail

Desired behavior after PR is merged:
DKIM checks work

Bugfix: DKIM checks fail
The DKIM key is base64 encoded, meaning it can end with "=" signs
Split on "=" and check if you have 2 'parts' (key and value) will fail in these cases.
By using split("=",1) we make sure we only slit on the first occurence of the "=" sign
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1648 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1648   +/-   ##
======================================
  Coverage    86.7%   86.7%           
======================================
  Files         150     150           
  Lines        7893    7893           
======================================
  Hits         6844    6844           
  Misses       1049    1049
@tonioo

This comment has been minimized.

Copy link
Member

tonioo commented Jan 9, 2019

@jammo-nl Thank you.

@tonioo tonioo merged commit 6f4ebf3 into modoboa:master Jan 9, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 70%)
Details
codecov/project 86.7% (+0%) compared to e26dd51
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tonioo tonioo referenced this pull request Jan 9, 2019

Open

dkim check fails #1647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment