Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression that caused the rounds parameter to be ignored #1686

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@Arvedui
Copy link
Contributor

Arvedui commented Feb 28, 2019

Description of the issue/feature this PR addresses:
A regression introduces about year ago caused the rounds parameter to be ignored

Current behavior before PR:
The rounds parameter is ignore, passlib always uses the default which for sha512_crypt is 656000.

Desired behavior after PR is merged:
The rounds parameter is honored.
You can verify this by setting it to != 656000 and the password hash to sha{256,512}_crypt.
Then update the pw and verify the result in the password field of the core_user table

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #1686 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
- Coverage   86.71%   86.71%   -0.01%     
==========================================
  Files         150      150              
  Lines        7899     7896       -3     
==========================================
- Hits         6850     6847       -3     
  Misses       1049     1049
@tonioo

This comment has been minimized.

Copy link
Member

tonioo commented Mar 1, 2019

@Arvedui Thank you!

@tonioo tonioo added this to the 1.13.2 milestone Mar 1, 2019

@tonioo tonioo added the bug label Mar 1, 2019

@tonioo tonioo merged commit dd2e8ab into modoboa:master Mar 1, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 70%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +13.28% compared to 404f4bc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.