Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 support #1812

Merged
merged 10 commits into from Jan 13, 2020
Merged

Remove Python 2 support #1812

merged 10 commits into from Jan 13, 2020

Conversation

@jeromelebleu
Copy link
Contributor

jeromelebleu commented Jan 2, 2020

Python 2 support has ended yesterday - i.e. 2020-01-01... This drops Python 2.7 from Modoboa and update the code to move to Python 3 only:

  • Update each dependency to the most recent version which doesn't require big changes - i.e. Django and Django REST Framework are not updated to the last release because of that
  • Remove coding header and __future__ imports
  • Remove use of six
  • In setup.py, remove use of io.open, add python_requires and update classifiers
  • In README.rst, specify the Python 3 version support
  • In .travis.yml and tox.ini, stop testing on Python 2
  • In setup.cfg, remove [bdist_wheel] section
@jeromelebleu jeromelebleu force-pushed the jeromelebleu:drop-python2 branch from 4313db2 to c9be66c Jan 2, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1812 into master will decrease coverage by 0.33%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master    #1812      +/-   ##
==========================================
- Coverage   86.74%   86.41%   -0.34%     
==========================================
  Files         154      154              
  Lines        8045     7759     -286     
==========================================
- Hits         6979     6705     -274     
+ Misses       1066     1054      -12
@jeromelebleu jeromelebleu force-pushed the jeromelebleu:drop-python2 branch 4 times, most recently from 4f1595e to ba69d41 Jan 5, 2020
jeromelebleu added 10 commits Jan 1, 2020
Each package version is updated to use the last one if it doesn't
require code changes. Only Django REST Framework is currently stuck on
release 3.7 since breaking changes and deprecations come with newer
releases.
See: https://www.django-rest-framework.org/community/3.9-announcement/

The 3.10 release begins the deprecation process for the CoreAPI based
schema generation and requires thus more changes - especially for the
documentation.
@jeromelebleu jeromelebleu force-pushed the jeromelebleu:drop-python2 branch from ba69d41 to a9ef9b7 Jan 7, 2020
@jeromelebleu

This comment has been minimized.

Copy link
Contributor Author

jeromelebleu commented Jan 7, 2020

I had a look at the coverage decrease and I didn't really find lines that are not covered anymore. I think it is probably a side effect of the from __future__ import ... and other lines removal.

@tonioo

This comment has been minimized.

Copy link
Member

tonioo commented Jan 13, 2020

@jeromelebleu is this PR ready to merge?

@jeromelebleu

This comment has been minimized.

Copy link
Contributor Author

jeromelebleu commented Jan 13, 2020

Yes! #1818 may be merged first - except that tests fail with Python 2.7 - but it doesn't really matter.

@tonioo

This comment has been minimized.

Copy link
Member

tonioo commented Jan 13, 2020

@jeromelebleu Great. Thank you!

@tonioo tonioo merged commit 4fb6147 into modoboa:master Jan 13, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/project 86.41% (-0.34%) compared to db12a4a
Details
codecov/patch 84% of diff hit (target 70%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.