Django 1.5 support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MODEL_NAME_archive_year.html uses 'year' the context of YearArchiveView. But, on Django 1.5, it is returned as a date object. So the template must use 'year.year'. In order to maintain backward compatibility, add context_keys and set proper key depending on the version of Django.
|
Thanks very much for your contribution! I will release this to PyPI as soon as possible, until then please use this SHA. Currently the CI only tests Python 2.7 & Django 1.4, but I plan on adding tests which use Django 1.5. Any help would be very much appreciated! See: #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put quotes around the first parameter of url template tags
The first parameter do not allow unquoted string since Django 1.5.
Add context_keys to TemplatesGenerator
MODEL_NAME_archive_year.html uses 'year' the context of YearArchiveView.
But, on Django 1.5, it is returned as a date object.
So the template must use 'year.year'.
In order to maintain backward compatibility, add context_keys and set proper key depending on the version of Django.