Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a menu for swift package commands and execute them with runTask #10

Merged
merged 1 commit into from Jul 14, 2016

Conversation

@Fortisque
Copy link
Collaborator

@Fortisque Fortisque commented Jul 14, 2016

#3

Tried adding a shortcut for new package, not sure if it's legit or what the other shortcuts should look like

init has a few types: library|executable|system-module, but this ignores that for now, and also init uses the path to swift instead of perhaps prompting the user where the new package should go

const commandArgs = [
'package',
'init',
'--chdir', store.getChdir(),

This comment has been minimized.

@modocache

modocache Jul 14, 2016
Owner

Awesome! Glad to see swift package supports --chdir.

'nuclide-swift:generate-xcode-project': () => _getBuildSystem().runTask('generate-xcode-project'),
'nuclide-swift:visualize-package-dependencies': () => _getBuildSystem().runTask('visualize-package-dependencies'),
'nuclide-swift:display-buffer-description': () => _getBuildSystem().runTask('display-buffer-description')
}),

This comment has been minimized.

@modocache

modocache Jul 14, 2016
Owner

Awesome! In another commit, we should register Atom commands for swift build and swift test, too.

@modocache
Copy link
Owner

@modocache modocache commented Jul 14, 2016

This is great!! Maybe we should add a separate menu item for each of the swift package init types in a future commit.

@modocache modocache merged commit 9d807fa into modocache:nuclide-swift Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants