Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theseus Skin Manager #1277

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Theseus Skin Manager #1277

wants to merge 27 commits into from

Conversation

Jakobabs
Copy link

@Jakobabs Jakobabs commented Jul 9, 2024

Adds a skin manager page to the app, where users can view/change their current skin, as well as store saved skins.

image_2024-07-09_154746157
image_2024-07-09_154825415

Resolves #415
Resolves #866

(Note the input search bar is broken across the whole app since monorepo change, and is not a skin manager issue
Edit: this has been fixed)

@IntMarco
Copy link

IntMarco commented Jul 9, 2024

First of all thank you, I've been waiting for this feature for a long time.
I would like to suggest some improvements about your work.

Main skin manager window:

Regarding the main screen, I suggest you order "Add new skin" as the last one, in my opinion it makes more sense for it to be at the end.

Change skin window:

I suggest you leave a small empty space under "Cape" section

Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).

Lastly, I think it is redundant to use 3 different buttons for use, save and save+use. I think using the skin without saving it doesn't make much sense as the user can delete or modify it immediately afterwards anyway.

  • New skin: Cancel* | Upload (Means use+save)
  • Saved skin: Cancel* | Delete | Save | Re-Upload (Means save+use)

*Redundant as it is already present in the top right corner (the X could be replaced with the 'Cancel' buttom).

@Jakobabs
Copy link
Author

Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).

I'll make it so the "add new skin" button autofills the current skin, so you can change the cape or arms and click upload.
The cancel buttons are on all modals in the app, so removing it would go against the current modal styling

@IntMarco Thank you for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Skins page In-app skin uploading functionality
3 participants