Skip to content

Fix normalized skins uploading to Mojang #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2025
Merged

Fix normalized skins uploading to Mojang #4646

merged 2 commits into from
Oct 26, 2025
+25 −17

Conversation

@Jerozgen
Copy link
Contributor

When determining the model type or uploading to the Mojang API, a non-normalized skin texture is now used

@Jerozgen
Copy link
Contributor Author

Fixes #4501

@IMB11 IMB11 added app Relates to Modrinth App frontend Involves work from the frontend team labels Oct 26, 2025
IMB11
IMB11 approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IMB11 IMB11 enabled auto-merge October 26, 2025 12:48
auto-merge was automatically disabled October 26, 2025 13:05

Head branch was pushed to by a user without write access

AlexTMjugador
AlexTMjugador approved these changes Oct 26, 2025
View reviewed changes
Copy link
Member

@AlexTMjugador AlexTMjugador left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've also tested this and it seems to work well, even if you restart the app and choose a saved skin.

@AlexTMjugador AlexTMjugador added this pull request to the merge queue Oct 26, 2025
@AlexTMjugador AlexTMjugador mentioned this pull request Oct 26, 2025
Closed
3 tasks
Merged via the queue into modrinth:main with commit a0f23a2 Oct 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

@IMB11 IMB11 IMB11 approved these changes

Assignees

No one assigned

Labels

app Relates to Modrinth App frontend Involves work from the frontend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jerozgen @AlexTMjugador @IMB11