Allow compiling and linking to be done on separate platforms #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of OS cross compile limitations in mojo (see previous commits), compile actions must be pinned to the target OS. Because the mojo toolchain was set on the top level rule, all resolved toolchains were pinned to the target OS, which meant linking could not be cross compiled. This removes that restriction using exec_groups to free up macOS CPU time when cross compiling.
keith
force-pushed
the
ks/allow-compiling-and-linking-to-be-done-on-separate-platforms
branch
from
83b4046 to
7efe0c9
Compare
keith
deleted the
ks/allow-compiling-and-linking-to-be-done-on-separate-platforms
branch
modularbot
pushed a commit
to modular/modular
that referenced
this pull request
Sep 16, 2025
To pull in modular/rules_mojo#53 MODULAR_ORIG_COMMIT_REV_ID: e5b6e1be99f6f0ea4c6692f23135d0f87bb7bfd8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of OS cross compile limitations in mojo (see previous commits),
compile actions must be pinned to the target OS. Because the mojo
toolchain was set on the top level rule, all resolved toolchains were
pinned to the target OS, which meant linking could not be cross
compiled. This removes that restriction using exec_groups to free up
macOS CPU time when cross compiling.