Skip to content

Conversation

@fi3ework
Copy link
Contributor

Description

only ship ESM outputs, align with Storybook 10.

in Storybook 10 https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-9x-to-1000, it's only to only ship ESM for the ecosystem.

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: 17b9b87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@module-federation/storybook-addon Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 17b9b87
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/691d729b1b86530007c228ff
😎 Deploy Preview https://deploy-preview-4223--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fi3ework
Copy link
Contributor Author

cc @2heal1 the current implementation has a ESM/CJS interop issue with Storybook 10. since Storybook 10 has fully turn to ESM only, i think it might be a chance to do the same thing here.

@2heal1 2heal1 merged commit 64840dd into module-federation:main Nov 19, 2025
19 checks passed
@2heal1 2heal1 mentioned this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants