From bb778e0fe8aa55fed0c212b4614fd4eeede70dcc Mon Sep 17 00:00:00 2001 From: Zack Jackson <25274700+ScriptedAlchemy@users.noreply.github.com> Date: Sat, 20 Sep 2025 19:22:54 -0700 Subject: [PATCH] fix: resolve TypeScript e2e test name and header expectations --- cypress-e2e/fixtures/commonTestData.ts | 8 ++++++-- typescript/e2e/tests/commonChecks.spec.ts | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/cypress-e2e/fixtures/commonTestData.ts b/cypress-e2e/fixtures/commonTestData.ts index 428edb69295..90c067da050 100644 --- a/cypress-e2e/fixtures/commonTestData.ts +++ b/cypress-e2e/fixtures/commonTestData.ts @@ -2,6 +2,10 @@ import { getRandomTextString } from '../helpers/base-helper'; import { Constants } from './constants'; import { baseSelectors, selectors } from '../common/selectors'; +const typescriptHeader = + Constants.commonConstantsData.typeScript.charAt(0).toUpperCase() + + Constants.commonConstantsData.typeScript.slice(1); + export class CommonTestData { public static readonly multipleSizeStringsArray = [ getRandomTextString(10), @@ -44,12 +48,12 @@ export class CommonTestData { public static readonly commonTypeScriptAppsData = [ { host: 3001, - header: Constants.commonConstantsData.typeScript.charAt(0).toUpperCase(), + header: typescriptHeader, appName: Constants.commonConstantsData.commonCountAppNames.app1, }, { host: 3002, - header: Constants.commonConstantsData.typeScript.charAt(0).toUpperCase(), + header: typescriptHeader, appName: Constants.commonConstantsData.commonCountAppNames.app2, }, ]; diff --git a/typescript/e2e/tests/commonChecks.spec.ts b/typescript/e2e/tests/commonChecks.spec.ts index c564d4f727b..6b3b177f394 100644 --- a/typescript/e2e/tests/commonChecks.spec.ts +++ b/typescript/e2e/tests/commonChecks.spec.ts @@ -54,7 +54,7 @@ test.describe('Typescript', () => { await expect(page.locator(baseSelectors.tags.headers.h2)).toHaveText(app.appName); }); - test(`checks both apps share ${primaryAppButtons.small}`, async ({ page }) => { + test(`checks both apps share ${primaryAppButtons.small} (port: ${app.host})`, async ({ page }) => { await navigateToApp(page, app.host); await expect(page.getByRole('button', { name: primaryAppButtons.small })).toBeVisible();