You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It'd be nice to consolidate all our resource loading in one place.
As such, we should get rid of the resource loading code from this module and have it use window-fetch.
We should have it require window-fetch by default, and have an option for specifying the fetch implementation for custom stuff.
We'll be making a tradeoff by getting rid of cancellation. We'll still have it act like it's cancelled the request, but fetch will still resolve in the background. This could be addressed later if we introduce the cancellation signal API to window-fetch.
We might also be missing out on exceptions that would normally be thrown inside open for invalid protocols and URLs.
Steps:
Convert between formdata and fetch body
Find mappings between status codes and stuff between xhr and fetch
Replace file/HTTP handling inside open() with call to fetch()
Implement abort() which sets the aborted status, but doesn't cancel the fetch call
Test that it works!
The text was updated successfully, but these errors were encountered:
It'd be nice to consolidate all our resource loading in one place.
As such, we should get rid of the resource loading code from this module and have it use window-fetch.
We should have it require window-fetch by default, and have an option for specifying the fetch implementation for custom stuff.
We'll be making a tradeoff by getting rid of cancellation. We'll still have it act like it's cancelled the request, but fetch will still resolve in the background. This could be addressed later if we introduce the cancellation signal API to window-fetch.
We might also be missing out on exceptions that would normally be thrown inside
open
for invalid protocols and URLs.Steps:
open()
with call tofetch()
abort()
which sets the aborted status, but doesn't cancel the fetch callThe text was updated successfully, but these errors were encountered: