From ba131f8de94dce54fe1b3f2d7afb5b24026cd99d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=9F=D0=B0=D0=B2=D0=B5=D0=BB=20=D0=93=D0=B2=D0=BE=D0=B7?= =?UTF-8?q?=D0=B4=D1=8C?= Date: Fri, 6 Nov 2020 12:41:47 +0600 Subject: [PATCH] Fix bug `property 'id' of undefined` #466 Fix bug `property 'id' of undefined` in miniShop2 2.6.0. --- .../minishop2/js/mgr/category/category.common.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/assets/components/minishop2/js/mgr/category/category.common.js b/assets/components/minishop2/js/mgr/category/category.common.js index 0593c3fe0..ab8ec565f 100644 --- a/assets/components/minishop2/js/mgr/category/category.common.js +++ b/assets/components/minishop2/js/mgr/category/category.common.js @@ -24,6 +24,7 @@ Ext.extend(miniShop2.panel.Category, MODx.panel.Resource, { item.getState = function () { return {activeTab: this.items.indexOf(this.getActiveTab())}; }; + var pageSettingsTab, accessPermissionsTab; for (var i2 in item.items) { if (!item.items.hasOwnProperty(i2)) { continue; @@ -35,16 +36,17 @@ Ext.extend(miniShop2.panel.Category, MODx.panel.Resource, { } else if (tab.id == 'modx-page-settings') { tab.items = this.getCategorySettings(config); - var pageSettingsTab = tab; + pageSettingsTab = tab; item.items.splice(i2, 1); } else if (tab.id == 'modx-resource-access-permissions') { - var accessPermissionsTab = tab; + accessPermissionsTab = tab; item.items.splice(i2, 1); } } // Move the "Settings" and "Resource Groups" to the end of tabs - item.items.push(pageSettingsTab, accessPermissionsTab); + pageSettingsTab && item.items.push(pageSettingsTab); + accessPermissionsTab && item.items.push(accessPermissionsTab); } if (item.id != 'modx-resource-content') { fields.push(item); @@ -166,4 +168,4 @@ Ext.extend(miniShop2.panel.Category, MODx.panel.Resource, { }, }); -Ext.reg('minishop2-panel-category', miniShop2.panel.Category); \ No newline at end of file +Ext.reg('minishop2-panel-category', miniShop2.panel.Category);