Add Git Package Management build config #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugopeek
added a commit
to hugopeek/pThumb
that referenced
this pull request
Sep 19, 2021
This allows you to run a custom snippet after the thumbnail has been generated. Useful for further optimization with other libraries. This PR needs to implement the pthumb.post_hook system setting still, but I don't know how to do that in the current configuration. It's very simple with GPM, so I vote to merge modxcms#68 from Joeke first.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a GPM build config to be able to use pThumb with Git Package Management.
Also fixes the loadClass method call in phpthumbof snippet file to allow for custom core_path, as used by GPM.