Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fields in custom TV tab are too wide #11758

Closed
SnowCreative opened this issue Jul 21, 2014 · 6 comments
Closed

Text fields in custom TV tab are too wide #11758

SnowCreative opened this issue Jul 21, 2014 · 6 comments

Comments

@SnowCreative
Copy link
Contributor

The input fields in the custom tabs I set up are too wide now. Rich Text textareas extend beyond the right edge of the containing white area, so scrollbars are inaccessible. Regular text fields are just as wide, but get repositioned under the labels. Screen shots:

[img]http://snowcreative.com/modx23screenshot2.png[/img]

[img]http://snowcreative.com/modx23screenshot3.png[/img]

@exside
Copy link
Contributor

exside commented Jul 21, 2014

Damn, thanks for reporting...why are these custom tabs not consitent with other tabs and have the labels on the left?^^...would it be ok if they were above the fields?

@exside
Copy link
Contributor

exside commented Jul 21, 2014

Is this #11761 an acceptable solution?

@SnowCreative
Copy link
Contributor Author

That looks great, and makes it consistent with how the regular TV tab behaves. I just made the one change in modx.js, and the issue is fixed for me!

@exside
Copy link
Contributor

exside commented Jul 21, 2014

the top label thing is very easy, just add that ,labelAlign: 'top' in modx.js (see files changed), for the css, you need to either rebuild the sass by yourself or you just take the already compiled css from my branch here: http://testgit.exside.com/manager/templates/default/css/index.customfctabsfix.css , rename it to index.css, then replace yours inside manager/templates/default/css/

@SnowCreative
Copy link
Contributor Author

It looks like you've added a left indent, and I'm not sure why. It doesn't conform to the other tabs this way. I've gone back to the original index.css and it looks fine to me that way.

@exside
Copy link
Contributor

exside commented Jul 21, 2014

because of the tv reset button, hover over a tv label to see it cut off =)

opengeek added a commit that referenced this issue Jul 21, 2014
Addresses #11758

Merge remote-tracking branch 'origin/pr/11761'

* origin/pr/11761:
  Fix labels / tvs in custom FC tabs
@Mark-H Mark-H closed this as completed Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants