Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.2-pl, Manager: In some grids the columns are not sortable #12299

Open
ottogal opened this issue Jan 27, 2015 · 5 comments
Open

2.3.2-pl, Manager: In some grids the columns are not sortable #12299

ottogal opened this issue Jan 27, 2015 · 5 comments
Assignees
Labels
feature Request about implementing a brand new function or possibility. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Comments

@ottogal
Copy link

ottogal commented Jan 27, 2015

The sorting options in the Extras>Installer grid are deactivated (grayed-out); same with the Messages grid.

@pepebe
Copy link

pepebe commented Jan 27, 2015

Unsortable columns can be found in many places. Before issues moved over to github, I wrote a bug report about this and I think Jason Coward wrote back that this behavior was not intended but somehow happened along the way.

Should be easy to fix, but unfortunately this problem is not among the current top 100 list of issues.

It would be great to have a complete list of all grids that come along with unsortable columns, so somebody could do some research.

@whitebyte
Copy link

Well, i partially managed to fix it. It's pretty easy to enable sorting in grid by modifying lines 32-36 in manager/assets/modext/workspace/package.grid.js (see gist - https://gist.github.com/whitebyte/58025c5d5cbf28e9fb35). You can use it as a quick-fix, i'll make a proper pull request later.

@pepebe
Copy link

pepebe commented Jan 27, 2015

@whitebyte Thanks for your fix.

I think its worth to have a look at all files including "sortable: false":

https://github.com/modxcms/revolution/search?utf8=%E2%9C%93&q=%22sortable%3A+false%22&type=Code

(17 results)

I'm sure there will be more columns suffering from this problem.

@pepebe
Copy link

pepebe commented Feb 2, 2015

Related to this: #12319

@alroniks
Copy link
Collaborator

@Ruslan-Aleev Seems you can have a look at this.

@alroniks alroniks added the type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. label Mar 29, 2021
@Ruslan-Aleev Ruslan-Aleev self-assigned this Mar 29, 2021
@alroniks alroniks added the feature Request about implementing a brand new function or possibility. label Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request about implementing a brand new function or possibility. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

No branches or pull requests

5 participants