New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent Fail on Login where User doesn't have mgr Context access. #12706

Closed
jaygilmore opened this Issue Oct 9, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@jaygilmore
Member

jaygilmore commented Oct 9, 2015

Uers who are in User Groups that do not have access permissions for the manager (mgr) context who attempt to login to the MODX Manager will see the login page reload and silently fail. It appears that upon submit, the manager page reloads, a 301 redirects to the manager with no trailing slash eg: manager and then 302 to manager/.

This should not fail silently, should it?

@bezumkin

This comment has been minimized.

Collaborator

bezumkin commented Feb 9, 2018

I will try to fix it

Mark-H added a commit that referenced this issue Feb 9, 2018

Fix silent fail on login without manager access [#12706]
Merge remote-tracking branch 'upstream/pr/13767' into 2.6.x

* upstream/pr/13767:
  Prevent reload of login page
  Fix silent fail on login
@OptimusCrime

This comment has been minimized.

Contributor

OptimusCrime commented Feb 11, 2018

Is this fixed then?

@gpsietzema

This comment has been minimized.

Collaborator

gpsietzema commented Feb 12, 2018

Jup 👍 🎉

@bezumkin

This comment has been minimized.

Collaborator

bezumkin commented Feb 12, 2018

I think Optimus asked about to close this issue. Lets try this magic!

@Mark-H close

@Mark-H

This comment has been minimized.

Collaborator

Mark-H commented Feb 12, 2018

/me puts on modxbot hat

@Mark-H Mark-H closed this Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment