HHVM errors

[johanmolen]

Summary

Having the following errors with MODX 2.4.2-pl on a HHVM machine.

Deprecated: ereg: As of PHP 5.3.0, preg_match is suggested instead in /var/www/vhosts/vv-domain.com/production/core/model/phpthumb/modphpthumb.class.php on line 160

Warning: Session callback expects true/false return value in /var/www/vhosts/domain.com/production/core/model/modx/modx.class.php on line 2441

Also noticed that the multi select tv fails on HHVM, for the time being im running the manager in PHP-FPM.

Thanks in advance.

[exside]

The first one would be fixed in #12809 (I believe, would be nice if you can test)

[johanmolen]

Alright gonna test it as soon as possible!

Thanks!

[exside]

and for the second one I'm lost...seems to be something in that block of code

                $sh= false;
                if ($sessionHandlerClass = $this->getOption('session_handler_class', $options)) {
                    if ($shClass= $this->loadClass($sessionHandlerClass, '', false, true)) {
                        if ($sh= new $shClass($this)) {
                            session_set_save_handler(
                                array (& $sh, 'open'),
                                array (& $sh, 'close'),
                                array (& $sh, 'read'),
                                array (& $sh, 'write'),
                                array (& $sh, 'destroy'),
                                array (& $sh, 'gc')
                            );
                        }
                    }
                }
                if (!$sh) {
                    $sessionSavePath = $this->getOption('session_save_path', $options);
                    if ($sessionSavePath && is_writable($sessionSavePath)) {
                        session_save_path($sessionSavePath);
                    }
                }

line 2441 is if (!$sh) {

and $sh is by default an instance of modSessionHandler (core/model/modx/modsessionhandler.class.php) and that classe's methods seem to definitely return other things than true or false...but I'm not sure how to fix that without breaking things...maybe @opengeek has a hint?

[johanmolen]

Will try to take a look at it on Sunday!