New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.8] Endless refresh loop when error.log gets too big #13631

Closed
pixelchutes opened this Issue Oct 10, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@pixelchutes
Collaborator

pixelchutes commented Oct 10, 2017

Summary

If the MODX error.log gets too large to view, the current fallback option is to display a download button to pull down the large log file vs. showing the entire contents client-side.

However, I believe since #13560, this now results in an "endless loop," constantly refreshing the Error Log page if the log file gets too big.

Step to reproduce

  1. For example, fill your error.log to 10MB in size (or whatever the threshold is).
  2. Browse to Error Log page in MODX manager
  3. Watch as the page gets caught in a never-ending refresh loop.

Observed behavior

Page refreshes, over and over.

Expected behavior

No refresh should happen.

Related

#13560 /cc @bezumkin @Alroniks

Environment

MODX 2.5.8-pl, Chrome v63 / macOS

opengeek added a commit that referenced this issue Oct 15, 2017

Fix endless loop when error log is too big
Merge remote-tracking branch 'origin/pr/13632' into 2.x

* origin/pr/13632:
  Fix for #13631
@Jako

This comment has been minimized.

Collaborator

Jako commented Oct 23, 2017

Fixed by #13632

@Jako Jako closed this Oct 23, 2017

opengeek added a commit that referenced this issue Oct 27, 2017

Merge remote-tracking branch 'origin/2.x' into 3.x
* origin/2.x: (105 commits)
  Revert "Sync 2.5 and 2.x changelogs to ensure a complete history"
  Update translations
  Sync 2.5 and 2.x changelogs to ensure a complete history
  Enable sorting by 'assigned' column in template variable grid
  Return better error message if group name already exists
  Hide empty template variable tabs in the resource panel
  Wrong indent
  Refactor setUserGroups/addUsers methods - Don't remove the user from all existing groups and add it afterwards to all belonging groups - Invoke 'OnUserBeforeAddToGroup' and 'OnUserAddToGroup'
  Adding padding top for new .modx-alert and .modx-confirm classes
  Merge all context settings and pass them as options to filterPathSegment
  Fixing issue 13640. Was already discussed here: https://github.com/modxcms/revolution/pull/13245/files/c43a25483b0e39a0a6e8fa700f7f96ecc33475d1#r95083093
  Fixes issue #13639
  Make buttongroup visible again - Fixing #13612 caused by #13543
  Fetch Lexicon languages and topics from DB as well as file system
  Add OPTIONS request method Used in cross-origin HTTP request - https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS - http://zacstewart.com/2012/04/14/http-options-method.html
  Add new Who's Online dashboard widget
  Additional SVG preview improvements
  Enable rendering of SVG previews in Media Browser
  Fix site_status issue when a session is not available
  Fix for #13631
  ...

wuuti pushed a commit to wuuti/revolution that referenced this issue Feb 7, 2018

wuuti pushed a commit to wuuti/revolution that referenced this issue Feb 7, 2018

wuuti pushed a commit to wuuti/revolution that referenced this issue Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment