New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't work middle mouse button click on Trash manager button #14190

Open
GulomovCreative opened this Issue Dec 8, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@GulomovCreative
Copy link

GulomovCreative commented Dec 8, 2018

Feature

Summary

Don't work middle mouse and Ctrl + Left mouse buttons click on Trash manager button

Expected behavior

Open the Trash manager in new tab

Environment

MODX 2.7.0-pl

@Jako

This comment has been minimized.

Copy link
Collaborator

Jako commented Dec 9, 2018

That will be a larger rewrite and has to go into 3.x. It is a button now and not a link, so it does not have a target, if I remember right.

@Jako Jako added this to the v3.0.0-alpha milestone Dec 9, 2018

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Dec 11, 2018

You are right @Jako, it's a button with a handler that redirects on click:

'handler' => 'new Function("this.redirect(\"?a=resource/trash\");");'

@Ruslan-Aleev

This comment has been minimized.

Copy link
Contributor

Ruslan-Aleev commented Dec 14, 2018

Related issue - #14242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment