New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Additional resource trees #14216

Open
Ruslan-Aleev opened this Issue Dec 25, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@Ruslan-Aleev
Copy link
Contributor

Ruslan-Aleev commented Dec 25, 2018

Bug report

Summary

In the "Resource Groups", "Import site from HTML" and "Import resources from static files" sections, the additional resource tree does not work correctly:

  1. There are action icons on the right (update the tree, create a resource, create a child resource), but these icons do not work and they are not needed there.
  2. Tips for these icons are displayed incorrectly.

resource_tree

  1. In the "Resource Groups" section, you can go to editing the resource by clicking on the resource. But if you add a resource to a group, editing on click is no longer working.
    In general, editing is not needed here, because resources are added to groups by dragging (you can click wrongly).
    Icons do not work in resources that are added to the group.

resource_tree_2

Expected behavior

The functionality of additional trees, in my opinion, should be the same as in the "Top Menu" section, without action icons and tips.

Environment

MODX 2.7

@Alroniks

This comment has been minimized.

Copy link
Collaborator

Alroniks commented Dec 25, 2018

I am not sure but it seems that this features used rarely. I would remove it from the core at all and replace by a 3rd extra.

@Ruslan-Aleev

This comment has been minimized.

Copy link
Contributor

Ruslan-Aleev commented Dec 25, 2018

@Alroniks Yes, in my opinion, export is not particularly used, but resource groups are useful for permission setting at least.
And how is MODX usage statistics collect? Is statistics collected at all?
May be, for example, enable analytics scripts in final versions 2.x and, with the permission of the site administrator, collect a click map, a conversion map, etc. to understand the functions that are used by MODX-users and are needed in core?

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Dec 28, 2018

I agree with @Ruslan-Aleev, Resource Groups are useful and should, in my opinion, not be removed from the core.

@Alroniks

This comment has been minimized.

Copy link
Collaborator

Alroniks commented Dec 29, 2018

In the issue described 3 points and sometimes it's difficult to answer properly for all of them. I agree that Resource Groups should be in the core, they are part of ACL system. Import can be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment