Bugfix for transport resolution, if the package is not found on the current provider #14260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jako
added
bug
This was referenced Jan 11, 2019
Mark-H
approved these changes
Jan 12, 2019
JoshuaLuckers
approved these changes
Jan 22, 2019
JoshuaLuckers
added
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Check $resolution for emptiness instead of false.
Why is it needed?
$resolution can't be false since it is initialised as array in https://github.com/modxcms/revolution/blob/2.x/core/model/modx/transport/modtransportprovider.class.php#L164
If a dependent package is not found in the provider of the package with the dependency, it is never found because of this bug.
Related issue(s)/PR(s)
#12666