New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS: Context #14342

Open
Ibochkarev opened this Issue Feb 7, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@Ibochkarev
Copy link
Contributor

Ibochkarev commented Feb 7, 2019

Bug report

Summary

Stored XSS: Context

Step to reproduce

Go to the Settings menu, then Contexts. Create or edit an existing context and insert <img src=# onerror=alert(1); />
russian inn - revista rusa en espana russian inn - 2019-02-07 16-29-12
web111 russian inn - revista rusa en espana russian inn - 2019-02-07 16-28-47 1

Observed behavior

The application processes the html tags or scripts and it is getting stored in the database.

Expected behavior

It should not accept any scripts or html tags.

Environment

MODX Revolution 2.7.0-pl

@OptimusCrime

This comment has been minimized.

Copy link
Contributor

OptimusCrime commented Feb 7, 2019

Does it also print the alert, or is that stripped out?

@Ibochkarev

This comment has been minimized.

Copy link
Contributor Author

Ibochkarev commented Feb 8, 2019

@OptimusCrime An example of execution can be seen here: #14341 Runs the same.

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Feb 9, 2019

Fixed in 3.x by merging PR #14344

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Feb 9, 2019

Sorry, PR #14344 didn't solve this particular case.

Ibochkarev added a commit to Ibochkarev/revolution that referenced this issue Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment