New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate laravel migrations in MODX #14343

Open
sdrenth opened this Issue Feb 7, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@sdrenth
Copy link
Contributor

sdrenth commented Feb 7, 2019

Feature request

Summary

I would like to know what people think of the idea of possibly integrating Laravel Migrations into the core of MODX.

Why is it needed?

Laravel migrations is a nice, simple and clean way for creating/altering the database and also makes it possible to revert database changes.

I think it would also come in handy for developers when working with MODX they can easily create a database migration, push to staging or production and run the migrations.

Also it keeps track of the migrations that already have been processed by using a custom migrations table.

If there is enough support for this idea, then maybe someone can pickup this idea later on to actually integrate this into the core. For now, this is just an idea and wanted to know what people think about this.

@sdrenth sdrenth changed the title Integrate laravel in MODX Integrate laravel migrations in MODX Feb 7, 2019

@Mark-H

This comment has been minimized.

Copy link
Collaborator

Mark-H commented Feb 7, 2019

"Should we integrate {$framework}" is putting the cart before the horse. We have APIs (xPDOManager) for database migrations that are used by core and extras. Apparently, those are not sufficient for your needs. Let's talk about the problem before jumping to a specific implementation to fix them.

@sdrenth

This comment has been minimized.

Copy link
Contributor Author

sdrenth commented Feb 7, 2019

@Mark-H You're right about that, we might as well use the same approach as Laravel Migration but using MODX APIs for it.

I think the general approach of laravel migrations would be very useful when developing in multiple environments (local/staging/production) and could be used for installing MODX core and making it also useful for developers when developing with MODX.

The migrations table comes in very handy to have a sort of "log" of which migrations have been completed.

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Feb 8, 2019

I prefer Phinx fro migrations. Maybe it's better to keep the freedom of choice and come up with ideas and solutions to make it possible to use whatever tool a developer prefers for migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment