New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webp format and MODX is not friend yet. #14355

Open
iWatchYouFromAfar opened this Issue Feb 9, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@iWatchYouFromAfar
Copy link

iWatchYouFromAfar commented Feb 9, 2019

Bug report

Summary

As you probably know, the format of webp images is becoming more and more relevant. If you do not know, then here's an article on Wikipedia - https://en.wikipedia.org/wiki/WebP.

In MODX there are several problems that I discovered while trying to work with this format. What I want to tell below.

Step to reproduce & Observed behavior

Problem 1.
Go to the settings and look for the key ** upload_images **. The description of the setting tells us that here we can specify the format of images that can be loaded into the assets/images/ folder. Specify the format webp and when you try to download the image in this folder, we get an error.

1

Improvement 1.
After our unsuccessful attempt to upload an image, look for the setting with the ** upload_files ** key and specify the wepb format there. After that, we successfully upload the image. Perhaps it is necessary to register this format by default in future versions?

Problem 2.
As you can see, the preview image in the webp format is not available for us to see. This is sad, because MODX modern CMS!

2

Observed behavior

Problem 1.
if I understood correctly, after specifying the format of the webp, we should easily upload the image to this directory?

Problem 2.
FTW We must see the preview!

Environment

PHP 7.2
MODX 2.7.0

@JoshuaLuckers

This comment has been minimized.

Copy link
Collaborator

JoshuaLuckers commented Feb 9, 2019

WebP is not supported by one of the major browsers. And if I’m not mistaken phpthumb doesn’t support WebP either.

@Ibochkarev

This comment has been minimized.

Copy link
Contributor

Ibochkarev commented Feb 9, 2019

WebP is not supported by one of the major browsers. And if I’m not mistaken phpthumb doesn’t support WebP either.

At the moment, phpthumb does not support the format of the webp as this issue says
JamesHeinrich/phpThumb#107.

I added a PR that changes the setting and registers this format in the list of allowed downloads.

@digitalpenguin

This comment has been minimized.

Copy link

digitalpenguin commented Feb 11, 2019

It looks like there's a PR adding this to phpthumb as of 4 hours ago.
JamesHeinrich/phpThumb@884abbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment